[REVIEW] updated clang version to 11.0.0 #3121
Conversation
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
Tagging @codereport , JFYI |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3121 +/- ##
============================================
Coverage 69.38% 69.38%
============================================
Files 193 193
Lines 14704 14704
============================================
Hits 10203 10203
Misses 4501 4501 Continue to review full report at Codecov.
|
teju85
added
breaking
|
@teju85 FYI this is targeting |
|
This PR has been labeled |
|
This PR has been labeled |
This resolves: #5187 PR description copied from: rapidsai/cuml#3121 Depends on: rapidsai/integration#304 This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See rapidsai/raft#88 for more details. CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass. ----- ### Fixes from Clang 8.0.1 to Clang 11.0.0 (that are observed in delta) * Missing spaces * Incorrect alignment when ternary expression splits across multiple lines * Comment alignment on macros * Fixed where function signatures have line breaks * Aligning macros * Always left align pointer/reference * Don't allow single line for loops ----- To do list: * [x] Update python file * [x] Update conda environment files * [x] Run formatter to apply all changes from upgrading * [x] Add changes from #5187 * [x] Review list of new changes from 8.0.1 to 11; choose which to incorporate * [x] Get working with RAPID compose Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Nghia Truong (https://github.com/ttnghia) - Mark Harris (https://github.com/harrism) - Dillon Cullinan (https://github.com/dillon-cullinan) URL: #6695
|
I believe this has been replaced by #4029 and can be closed. |
This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See rapidsai/raft#88 for more details.
CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass.