Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add QuasiNewton tests #3135

Merged
merged 4 commits into from
Nov 18, 2020
Merged

[REVIEW] Add QuasiNewton tests #3135

merged 4 commits into from
Nov 18, 2020

Conversation

Nanthini10
Copy link
Contributor

@Nanthini10 Nanthini10 commented Nov 12, 2020 •
edited
Loading

Adding test coverage for softmax option

The data is too small for convergence; so testing the accuracy score instead of coefficients.

Closes #1707

@Nanthini10 Nanthini10 requested a review from a team as a code owner November 12, 2020 21:50
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov-io
Copy link

codecov-io commented Nov 13, 2020 •
edited
Loading

Codecov Report

Merging #3135 (0879167) into branch-0.17 (77da916) will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3135      +/-   ##
===============================================
- Coverage        70.57%   70.17%   -0.40%     
===============================================
  Files              197      197              
  Lines            15461    15670     +209     
===============================================
+ Hits             10911    10997      +86     
- Misses            4550     4673     +123
Impacted Files Coverage Δ
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 58.48% <0.00%> (-4.97%) ⬇️
python/cuml/thirdparty_adapters/adapters.py 88.88% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77da916...0879167. Read the comment docs.

@Nanthini10 Nanthini10 changed the title [WIP] Add QuasiNewton tests [REVIEW] Add QuasiNewton tests Nov 13, 2020
divyegala
divyegala approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divyegala
Copy link
Member

Just leaving a comment for print statements

@Nanthini10
Copy link
Contributor Author

rerun tests

1 similar comment
@JohnZed
Copy link
Contributor

JohnZed commented Nov 18, 2020

rerun tests

@cjnolet cjnolet added 5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue tests Unit testing for project labels Nov 18, 2020
@dantegd dantegd merged commit d8b4765 into rapidsai:branch-0.17 Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Lack of test coverage for QuasiNewton
7 participants
@Nanthini10 @GPUtester @codecov-io @divyegala @JohnZed @dantegd @cjnolet