Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Make Multinomial Naive Bayes inherit from ClassifierMixin #3177

Merged
merged 4 commits into from
Dec 1, 2020
Merged

[REVIEW] Make Multinomial Naive Bayes inherit from ClassifierMixin #3177

merged 4 commits into from
Dec 1, 2020

Conversation

ChrisJar
Copy link
Contributor

To match match the other classifiers, this makes Multinomial Naive Bayes inherit from ClassifierMixin and use its score method

Passes Naive Bayes tests locally

This closes #2614

@ChrisJar ChrisJar requested a review from a team as a code owner November 23, 2020 21:25
@codecov-io
Copy link

codecov-io commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #3177 (25dd50c) into branch-0.17 (13600f7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3177      +/-   ##
===============================================
- Coverage        71.00%   70.99%   -0.01%     
===============================================
  Files              198      198              
  Lines            15750    15745       -5     
===============================================
- Hits             11183    11178       -5     
  Misses            4567     4567
Impacted Files Coverage Δ
python/cuml/naive_bayes/naive_bayes.py 92.02% <100.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13600f7...25dd50c. Read the comment docs.

cjnolet
cjnolet approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjnolet cjnolet added 5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue labels Nov 30, 2020
@cjnolet cjnolet mentioned this pull request Dec 1, 2020
Closed
@JohnZed JohnZed added 6 - Okay to Auto-Merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 1, 2020
Merge branch 'branch-0.17' of https://github.com/rapidsai/cuml into e…
25dd50c 
…nh-nbscore

Merge branch 'branch-0.17' into enh-nbscore
@rapids-bot rapids-bot bot merged commit 6cc3d1f into rapidsai:branch-0.17 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@cjnolet cjnolet

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Multinomial Naive Bayes should inherit from ClassifierMixin and use it for score
4 participants
@ChrisJar @codecov-io @cjnolet @JohnZed