Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gain to RF JSON dump #3186

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Add gain to RF JSON dump #3186

merged 2 commits into from
Dec 1, 2020

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Nov 25, 2020 •
edited
Loading

I found it helpful when debugging the MSE metric calculation in random forest.

Gain = Change in the metric (MSE / MAE / Gini / Entropy) that's attributed directly to each internal node (split).

@hcho3 hcho3 requested a review from a team as a code owner November 25, 2020 08:10
@hcho3 hcho3 changed the base branch from branch-0.17 to branch-0.18 November 25, 2020 08:10
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@hcho3 hcho3 changed the title Add gain to RF JSON dump [FEA] Add gain to RF JSON dump Nov 25, 2020
@hcho3 hcho3 added the CUDA / C++ CUDA issue label Nov 25, 2020
@hcho3 hcho3 mentioned this pull request Nov 25, 2020
Closed
@hcho3 hcho3 changed the base branch from branch-0.18 to branch-0.17 November 30, 2020 17:29
@hcho3 hcho3 added the 3 - Ready for Review Ready for review by team label Nov 30, 2020
@JohnZed JohnZed changed the title [FEA] Add gain to RF JSON dump [WIP] Add gain to RF JSON dump Nov 30, 2020
@JohnZed JohnZed added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Nov 30, 2020
@JohnZed
Copy link
Contributor

JohnZed commented Nov 30, 2020

Needs changelog update

@hcho3 hcho3 changed the title [WIP] Add gain to RF JSON dump Add gain to RF JSON dump Nov 30, 2020
@hcho3
Copy link
Contributor Author

hcho3 commented Nov 30, 2020

Needs changelog update

It's already there.

@JohnZed JohnZed added 6 - Okay to Auto-Merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed 4 - Waiting on Author Waiting for author to respond to review labels Dec 1, 2020
@rapids-bot rapids-bot bot merged commit 398200f into rapidsai:branch-0.17 Dec 1, 2020
@hcho3 hcho3 deleted the add_gain_to_rf_dump branch December 1, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
CUDA / C++ CUDA issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hcho3 @GPUtester @JohnZed