-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix __repr__ function for preprocessing models #3191
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you add a test demonstrating the new functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3191 +/- ##
===============================================
- Coverage 70.99% 70.53% -0.47%
===============================================
Files 198 199 +1
Lines 15729 16207 +478
===============================================
+ Hits 11167 11431 +264
- Misses 4562 4776 +214
Continue to review full report at Codecov.
|
|
a55a638
to
fbc9356
Compare
Closes #2963