Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix __repr__ function for preprocessing models #3191

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Nov 25, 2020

Closes #2963

@viclafargue viclafargue requested a review from a team as a code owner November 25, 2020 17:39
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@viclafargue viclafargue requested a review from wphicks November 25, 2020 17:39
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you add a test demonstrating the new functionality?

Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #3191 (fbc9356) into branch-0.17 (f1abcb8) will decrease coverage by 0.46%.
The diff coverage is 28.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3191      +/-   ##
===============================================
- Coverage        70.99%   70.53%   -0.47%     
===============================================
  Files              198      199       +1     
  Lines            15729    16207     +478     
===============================================
+ Hits             11167    11431     +264     
- Misses            4562     4776     +214     
Impacted Files Coverage Δ
python/cuml/_thirdparty/sklearn/utils/_pprint.py 27.71% <27.71%> (ø)
...cuml/_thirdparty/sklearn/utils/skl_dependencies.py 52.89% <100.00%> (+17.35%) ⬆️
...ython/cuml/dask/neighbors/kneighbors_classifier.py 20.48% <0.00%> (-1.52%) ⬇️
python/cuml/dask/neighbors/kneighbors_regressor.py 30.00% <0.00%> (-1.25%) ⬇️
python/cuml/common/input_utils.py 94.14% <0.00%> (+1.60%) ⬆️
python/cuml/thirdparty_adapters/adapters.py 90.17% <0.00%> (+1.61%) ⬆️
...cuml/experimental/decomposition/incremental_pca.py 88.94% <0.00%> (+2.28%) ⬆️
python/cuml/decomposition/pca.pyx 94.60% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1abcb8...fbc9356. Read the comment docs.

@viclafargue viclafargue changed the title [REVIEW] Fix __repr__ function for preprocessing models [WIP] Fix __repr__ function for preprocessing models Nov 30, 2020
@viclafargue
Copy link
Contributor Author

viclafargue commented Nov 30, 2020

I thought that it might be better to use cuML estimator Base class. It fixes the __repr__ problem. Unfortunately preprocessing is not fully compliant with this class yet. I'll create an issue to work on this. After second thought, I reverted the last commit as the usage of the cuML estimator Base class will require more time. I think that it can be done for the next release along with the exit outside of the experimental namespace.

@viclafargue viclafargue changed the title [WIP] Fix __repr__ function for preprocessing models [REVIEW] Fix __repr__ function for preprocessing models Nov 30, 2020
@JohnZed JohnZed added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Nov 30, 2020
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change labels Dec 1, 2020
@JohnZed JohnZed merged commit 966b85c into rapidsai:branch-0.17 Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ModuleNotFoundError when printing SimpleImputer
5 participants