-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Fix cuDF to cuPy conversion (missing value) #3194
[REVIEW] Fix cuDF to cuPy conversion (missing value) #3194
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple of questions
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3194 +/- ##
===============================================
+ Coverage 70.99% 71.03% +0.03%
===============================================
Files 198 198
Lines 15729 15737 +8
===============================================
+ Hits 11167 11178 +11
+ Misses 4562 4559 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Answers #2966 .
This change should probably be implemented in cuDF. In the meantime, I modified the
input_to_cupy_array
function to produce a proper conversion of cuDF Dataframe and Series to cuPy array even when they contain missing values. The data is upcasted to float64 when necessary.