Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix intermittent dask random forest failure #3239

Merged

Conversation

Nanthini10
Copy link
Contributor

Adding n_classes=1 when n_samples=1 to ensure that class is always labelled 0.

Closes #3202

@Nanthini10 Nanthini10 requested a review from a team as a code owner December 2, 2020 19:58
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@Nanthini10 Nanthini10 added the 3 - Ready for Review Ready for review by team label Dec 2, 2020
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird case! But fix looks good

@JohnZed JohnZed added 6 - Okay to Auto-Merge bug Something isn't working non-breaking Non-breaking change labels Dec 2, 2020
@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #3239 (5739fe7) into branch-0.17 (a0f4549) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3239      +/-   ##
===============================================
- Coverage        71.48%   71.35%   -0.14%     
===============================================
  Files              206      206              
  Lines            16645    16879     +234     
===============================================
+ Hits             11899    12044     +145     
- Misses            4746     4835      +89     
Impacted Files Coverage Δ
python/cuml/dask/neighbors/kneighbors_regressor.py 25.92% <0.00%> (-3.93%) ⬇️
...ython/cuml/dask/neighbors/kneighbors_classifier.py 18.60% <0.00%> (-2.70%) ⬇️
python/cuml/experimental/explainer/kernel_shap.pyx 97.74% <0.00%> (+0.48%) ⬆️
python/cuml/fil/fil.pyx 94.59% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0f4549...5739fe7. Read the comment docs.

@JohnZed
Copy link
Contributor

JohnZed commented Dec 2, 2020

rerun tests

1 similar comment
@JohnZed
Copy link
Contributor

JohnZed commented Dec 3, 2020

rerun tests

@rapids-bot rapids-bot bot merged commit 1287e86 into rapidsai:branch-0.17 Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [TEST] possible flaky test dask/test_random_forest.py
4 participants