-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Adding CodeCov Info for Dask Tests #3338
[REVIEW] Adding CodeCov Info for Dask Tests #3338
Conversation
rerun tests |
rerun tests |
rerun tests |
…n.Coverage error.
…ed. Temp trying to add parent commit ID to codecov upload
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good... just a question about the test nn exclusion and some extraneous ann.pyx code that is probably a reflection of a weird merge issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looked at the ann.pxd changes - all looks good. We lose the "inline" but these are not so perf critical that we should be concerned.
rerun tests |
@gpucibot merge |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3338 +/- ##
===============================================
+ Coverage 71.77% 79.33% +7.56%
===============================================
Files 212 225 +13
Lines 17075 17946 +871
===============================================
+ Hits 12256 14238 +1982
+ Misses 4819 3708 -1111
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Closes #3171
This PR adjusts the CI build script to generate code coverage output for the dask tests that are run separately from the rest of the cuML tests. Ideally, the
codecov
CLI will detect this additional output and automatically upload it.Still a WIP. Testing alternative upload methods for Codecov.io.