Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Adding CodeCov Info for Dask Tests #3338

Merged
merged 39 commits into from
Feb 18, 2021

Conversation

mdemoret-nv
Copy link
Contributor

Closes #3171

This PR adjusts the CI build script to generate code coverage output for the dask tests that are run separately from the rest of the cuML tests. Ideally, the codecov CLI will detect this additional output and automatically upload it.

Still a WIP. Testing alternative upload methods for Codecov.io.

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner January 4, 2021 23:41
@mdemoret-nv mdemoret-nv added 2 - In Progress Currenty a work in progress Dask / cuml.dask Issue/PR related to Python level dask or cuml.dask features. feature request New feature or request non-breaking Non-breaking change tests Unit testing for project labels Jan 4, 2021
@mdemoret-nv
Copy link
Contributor Author

rerun tests

@mdemoret-nv
Copy link
Contributor Author

rerun tests

ci/gpu/build.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Ops label Jan 11, 2021
@mdemoret-nv
Copy link
Contributor Author

rerun tests

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner January 13, 2021 00:34
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 13, 2021
@mdemoret-nv
Copy link
Contributor Author

rerun tests

@mdemoret-nv
Copy link
Contributor Author

rerun tests

@mdemoret-nv mdemoret-nv added the 3 - Ready for Review Ready for review by team label Feb 4, 2021
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... just a question about the test nn exclusion and some extraneous ann.pyx code that is probably a reflection of a weird merge issue?

ci/gpu/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
python/.coveragerc Show resolved Hide resolved
python/cuml/neighbors/ann.pxd Show resolved Hide resolved
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looked at the ann.pxd changes - all looks good. We lose the "inline" but these are not so perf critical that we should be concerned.

@mdemoret-nv
Copy link
Contributor Author

rerun tests

@mdemoret-nv mdemoret-nv added non-breaking Non-breaking change and removed non-breaking Non-breaking change labels Feb 9, 2021
@JohnZed JohnZed changed the base branch from branch-0.18 to branch-0.19 February 10, 2021 05:51
@JohnZed JohnZed requested review from a team as code owners February 10, 2021 05:51
@JohnZed
Copy link
Contributor

JohnZed commented Feb 10, 2021

@gpucibot merge

@mdemoret-nv
Copy link
Contributor Author

rerun tests

@github-actions github-actions bot added gpuCI gpuCI issue and removed CMake labels Feb 17, 2021
@codecov-io
Copy link

Codecov Report

Merging #3338 (915e1e9) into branch-0.19 (39c7262) will increase coverage by 7.56%.
The diff coverage is 71.72%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3338      +/-   ##
===============================================
+ Coverage        71.77%   79.33%   +7.56%     
===============================================
  Files              212      225      +13     
  Lines            17075    17946     +871     
===============================================
+ Hits             12256    14238    +1982     
+ Misses            4819     3708    -1111     
Flag Coverage Δ
dask 44.12% <14.67%> (?)
non-dask 71.62% <69.97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.61% <ø> (+0.07%) ⬆️
python/cuml/experimental/explainer/common.py 88.05% <42.85%> (-4.01%) ⬇️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.00% <50.00%> (-0.50%) ⬇️
python/cuml/neighbors/nearest_neighbors.pyx 92.43% <50.00%> (-0.29%) ⬇️
python/cuml/neighbors/ann.pyx 61.62% <61.62%> (ø)
python/cuml/common/import_utils.py 59.43% <66.66%> (+3.43%) ⬆️
python/cuml/experimental/explainer/base.pyx 67.06% <67.06%> (ø)
python/cuml/dask/common/utils.py 43.68% <83.33%> (+16.13%) ⬆️
python/cuml/experimental/explainer/kernel_shap.pyx 97.75% <100.00%> (+0.48%) ⬆️
...n/cuml/experimental/explainer/permutation_shap.pyx 98.82% <100.00%> (+0.84%) ⬆️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5687ea...915e1e9. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 9845e26 into rapidsai:branch-0.19 Feb 18, 2021
@mdemoret-nv mdemoret-nv deleted the enh-add-dask-codecov branch February 18, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue Dask / cuml.dask Issue/PR related to Python level dask or cuml.dask features. feature request New feature or request gpuCI gpuCI issue libcuml non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add Dask test code coverage to codecov.io
5 participants