-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ANN memory release bug #3391
Fix for ANN memory release bug #3391
Conversation
dac0dfc
to
a027bb9
Compare
Original error not reproducing but there was an error in fetch_20newsgroups (zlib compression error) |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #3391 +/- ##
===============================================
+ Coverage 71.48% 71.63% +0.14%
===============================================
Files 207 210 +3
Lines 16748 16924 +176
===============================================
+ Hits 11973 12123 +150
- Misses 4775 4801 +26
Continue to review full report at Codecov.
|
rerun tests |
a027bb9
to
61acc79
Compare
rerun tests |
@gpucibot merge |
Answers #3318
This may fix the error observed in CI.
Before the change, the memory manager handler was released first, then the FAISS index.
After the change, the FAISS index is released first, then the memory manager handler is released.