Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Remove defaults channel from conda build #3803

Merged

Conversation

jjacobelli
Copy link
Contributor

Remove defaults channel from conda build

Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function labels Apr 28, 2021
@jjacobelli jjacobelli requested a review from a team April 28, 2021 14:29
@jjacobelli jjacobelli self-assigned this Apr 28, 2021
@github-actions github-actions bot added the conda conda issue label Apr 28, 2021
@jjacobelli jjacobelli added the non-breaking Non-breaking change label Apr 28, 2021
@dantegd dantegd added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 3 - Ready for Review Ready for review by team labels Apr 28, 2021
@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Waiting on Reviewer Waiting for reviewer to review or respond labels Apr 28, 2021
@dantegd
Copy link
Member

dantegd commented Apr 28, 2021

@gpucibot merge

@dantegd
Copy link
Member

dantegd commented Apr 28, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Apr 28, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.20@f87ca91). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.20    #3803   +/-   ##
==============================================
  Coverage               ?   86.04%           
==============================================
  Files                  ?      225           
  Lines                  ?    17113           
  Branches               ?        0           
==============================================
  Hits                   ?    14725           
  Misses                 ?     2388           
  Partials               ?        0           
Flag Coverage Δ
dask 49.29% <0.00%> (?)
non-dask 77.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87ca91...ef7a124. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 3879b06 into rapidsai:branch-0.20 Apr 29, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Remove `defaults` channel from conda build

Authors:
  - Jordan Jacobelli (https://github.com/Ethyling)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#3803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants