Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exact TSNE fewer log statements #3808

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Exact TSNE fewer log statements #3808

merged 2 commits into from
Apr 30, 2021

Conversation

divyegala
Copy link
Member

closes #3792

@divyegala divyegala requested a review from a team as a code owner April 29, 2021 16:28
@divyegala divyegala added 3 - Ready for Review Ready for review by team CUDA / C++ CUDA issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed CUDA/C++ labels Apr 29, 2021
@dantegd
Copy link
Member

dantegd commented Apr 30, 2021

rerun tests

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 30, 2021
@dantegd
Copy link
Member

dantegd commented Apr 30, 2021

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.20@3879b06). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.20    #3808   +/-   ##
==============================================
  Coverage               ?   86.04%           
==============================================
  Files                  ?      225           
  Lines                  ?    17113           
  Branches               ?        0           
==============================================
  Hits                   ?    14725           
  Misses                 ?     2388           
  Partials               ?        0
Flag Coverage Δ
dask 49.29% <0.00%> (?)
non-dask 77.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3879b06...ab4f9d4. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 9a74d20 into rapidsai:branch-0.20 Apr 30, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@divyegala
Exact TSNE fewer log statements (rapidsai#3808)
1a5b5b1 
closes rapidsai#3792

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CUDA / C++ CUDA issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Make tsne (and potentially others) googletest less verbose by default in CI
3 participants
@divyegala @dantegd @codecov-commenter