Upgrade to Treelite 1.2.0 #3829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
commented
May 5, 2021
Comment on lines
+64
to
+66
| gpuci_conda_retry remove -c conda-forge -c rapidsai -c rapidsai-nightly -c nvidia \ | ||
| --force rapids-build-env rapids-notebook-env | ||
| gpuci_conda_retry install -c conda-forge -c rapidsai -c rapidsai-nightly -c nvidia treelite=1.2.0 |
There was a problem hiding this comment.
I will remove these lines once Treelite is upgraded in integration.
hcho3
added
Build or Dep
|
When I re-built cuML with dmlc/treelite#270 temporarily reverted, the Dask tests start passing again. It appears that dmlc/treelite#270 broke the in-memory serializer. I will investigate. |
|
Here is a hotfix to fix the bug in the binary serializer: dmlc/treelite#273. I will publish a new patch version 1.2.1 and submit a new PR to use that version in cuML. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version incorporates two major new features:
Depends on rapidsai/integration#265