Ensure GPU is used for input transposing of host arrays #3835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
improvement
|
Thanks @dantegd for the quick fix! |
dantegd
added
3 - Ready for Review
wphicks
approved these changes
May 6, 2021
|
rerun tests |
|
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #3835 +/- ##
===============================================
+ Coverage 85.96% 86.03% +0.06%
===============================================
Files 225 225
Lines 16986 17117 +131
===============================================
+ Hits 14602 14726 +124
- Misses 2384 2391 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cjnolet
approved these changes
May 7, 2021
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Closes issue rapidsai#3832 Related to rapidsai#3767 cc @teju85 and @venkywonka and @vinaydes who are working on RF Will be profiling the solution before flipping the PR to ready to review Quick profiling, on a 2070S laptop,average of 10 runs of a simple LinearRegression.fit (that expects data in `F` format), with a `X` matrix of 500 columns with 100000 rows shows: - Before the fix: ``` common.input_utils.input_to_cuml_array : 0.1795 s ``` - After the fix: ``` common.input_utils.input_to_cuml_array : 0.0632 s ``` Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#3835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #3832
Related to #3767
cc @teju85 and @venkywonka and @vinaydes who are working on RF
Will be profiling the solution before flipping the PR to ready to review
Quick profiling, on a 2070S laptop,average of 10 runs of a simple LinearRegression.fit (that expects data in
Fformat), with aXmatrix of 500 columns with 100000 rows shows: