Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review] change TargetEncoder's smooth argument from ratio to count #3876

Merged
merged 15 commits into from
Jul 22, 2021
Merged

[Review] change TargetEncoder's smooth argument from ratio to count #3876

merged 15 commits into from
Jul 22, 2021

Conversation

daxiongshu
Copy link
Contributor

The related issue is #3874

@daxiongshu daxiongshu requested a review from a team as a code owner May 19, 2021 08:59
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 19, 2021
@daxiongshu daxiongshu changed the title [Fea] change TargetEncoder's smooth argument from ratio to count [WIP] change TargetEncoder's smooth argument from ratio to count May 19, 2021
@daxiongshu daxiongshu mentioned this pull request May 19, 2021
Closed
@dantegd dantegd added 2 - In Progress Currenty a work in progress breaking Breaking change labels May 21, 2021
viclafargue
viclafargue approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Jul 11, 2021
@daxiongshu daxiongshu changed the base branch from branch-21.06 to branch-21.08 July 11, 2021 03:08
@daxiongshu daxiongshu requested review from a team as code owners July 11, 2021 03:08
@daxiongshu daxiongshu removed CMake CUDA/C++ breaking Breaking change conda conda issue gpuCI gpuCI issue labels Jul 11, 2021
@daxiongshu daxiongshu added non-breaking Non-breaking change feature request New feature or request labels Jul 11, 2021
@daxiongshu daxiongshu changed the title [WIP] change TargetEncoder's smooth argument from ratio to count [Review] change TargetEncoder's smooth argument from ratio to count Jul 11, 2021
@daxiongshu daxiongshu added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Jul 11, 2021
dantegd
dantegd requested changes Jul 11, 2021
View reviewed changes
python/cuml/preprocessing/TargetEncoder.py Outdated
Comment on lines 40 to 41
smooth : int (default=0)
Count of samples to smooth the encoding. 0 means no smoothing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a deprecation warning for using floats for one version since this is a public API breaking change. I wonder if perhaps it would be a good idea to accept either a float or int and behave accordingly as opposed to change to only accept int?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Float will work just fine.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@964f40e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #3876   +/-   ##
===============================================
  Coverage                ?   85.59%           
===============================================
  Files                   ?      230           
  Lines                   ?    18221           
  Branches                ?        0           
===============================================
  Hits                    ?    15596           
  Misses                  ?     2625           
  Partials                ?        0
Flag Coverage Δ
dask 48.14% <0.00%> (?)
non-dask 77.92% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 964f40e...8ec8e33. Read the comment docs.

@ajschmidt8 ajschmidt8 removed the request for review from a team July 12, 2021 14:38
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@daxiongshu
Copy link
Contributor Author

rerun tests

@dantegd
Copy link
Member

dantegd commented Jul 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 357e0b7 into rapidsai:branch-21.08 Jul 22, 2021
@daxiongshu daxiongshu deleted the fea_target_encoder_smooth branch August 31, 2021 21:18
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@daxiongshu
change TargetEncoder's smooth argument from ratio to count (rapidsai#…
f2cf99c 
…3876)

The related issue is rapidsai#3874

Authors:
  - Jiwei Liu (https://github.com/daxiongshu)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viclafargue viclafargue viclafargue approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daxiongshu @codecov-commenter @ajschmidt8 @dantegd @viclafargue