-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automerge #3939 [skip-ci] #3952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) URL: rapidsai#3937
Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Victor Lafargue (https://github.com/viclafargue) - AJ Schmidt (https://github.com/ajschmidt8) URL: rapidsai#3936
We had originally tried to ease the review process by separating the Python and CUDA/C++ layer code for HDBSCAN (see rapidsai#3773), and for the most part we have been separating the commits, however this made it very cumbersome to keep cherry-picking commits backwards so we abandoned rapidsai#3773 and continued working on this PR. Authors: - Corey J. Nolet (https://github.com/cjnolet) - Divye Gala (https://github.com/divyegala) Approvers: - Tamas Bela Feher (https://github.com/tfeher) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3821
This reverts part of 99a80c8 due to unknown failure on CTX11.2. I'm still running the CI docker script to see if I can reproduce it, so please do not merge it right now. Authors: - Jiaming Yuan (https://github.com/trivialfis) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#3942
Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Jordan Jacobelli (https://github.com/Ethyling) URL: rapidsai#3902
dantegd
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
non-breaking
Non-breaking change
labels
Jun 7, 2021
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
CMake
conda
conda issue
CUDA/C++
Cython / Python
Cython or Python issue
gpuCI
gpuCI issue
labels
Jun 7, 2021
Author: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai/dask-cuda#642
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Fix automerge rapidsai#3939 [skip-ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
bug
Something isn't working
CMake
conda
conda issue
CUDA/C++
Cython / Python
Cython or Python issue
gpuCI
gpuCI issue
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.