Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automerge #3939 [skip-ci] #3952

Merged
merged 8 commits into from
Jun 7, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jun 7, 2021

No description provided.

dantegd and others added 6 commits June 3, 2021 11:14
We had originally tried to ease the review process by separating the Python and CUDA/C++ layer code for HDBSCAN (see rapidsai#3773), and for the most part we have been separating the commits, however this made it very cumbersome to keep cherry-picking commits backwards so we abandoned rapidsai#3773 and continued working on this PR.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3821
This reverts part of 99a80c8 due to unknown failure on CTX11.2.  I'm still running the CI docker script to see if I can reproduce it, so please do not merge it right now.

Authors:
  - Jiaming Yuan (https://github.com/trivialfis)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#3942
@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 7, 2021
@dantegd dantegd requested review from a team as code owners June 7, 2021 15:11
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue labels Jun 7, 2021
@ajschmidt8 ajschmidt8 merged commit 3eec43d into rapidsai:branch-21.08 Jun 7, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants