Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some deprecation warnings in tests. #5436

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented May 24, 2023

This PR fixes a few separate warnings in pytests.

Examples:

../../../../../../opt/conda/envs/test/lib/python3.9/site-packages/hypothesis/_settings.py:467
  /opt/conda/envs/test/lib/python3.9/site-packages/hypothesis/_settings.py:467: HypothesisDeprecationWarning: `Healthcheck.all()` is deprecated; use `list(HealthCheck)` instead.
      The `hypothesis codemod` command-line tool can automatically refactor your code to fix this warning.
    note_deprecation(

../../../../../../opt/conda/envs/test/lib/python3.9/site-packages/cuml/internals/safe_imports.py:469
  /opt/conda/envs/test/lib/python3.9/site-packages/cuml/internals/safe_imports.py:469: DeprecationWarning: Please use `approx_fprime` from the `scipy.optimize` namespace, the `scipy.optimize.optimize` namespace is deprecated.
    return getattr(imported_module, symbol)

test_device_selection.py:192
  /__w/cuml/cuml/python/cuml/tests/test_device_selection.py:192: DeprecationWarning: `pytest_fixture_plus` and `fixture_plus` are deprecated. Please use the new alias `fixture`. See https://github.com/pytest-dev/pytest/issues/6475
    @pytest_fixture_plus(

@bdice bdice requested review from a team as code owners May 24, 2023 15:14
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels May 24, 2023
@@ -63,7 +63,7 @@ dependencies:
- rmm==23.6.*
- scikit-build>=0.13.1,<0.17.2
- scikit-learn==1.2
- scipy
- scipy>=1.8.0
Copy link
Contributor Author

@bdice bdice May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 1.8.0 or higher contains a deprecation warning telling users to use the namespace scipy.optimize instead of scipy.optimize.optimize. It might be possible to use scipy.optimize in earlier versions but I know this is a safe lower bound. v1.8.0 was released Feb 5, 2022 so it's fine to require versions that new.

@bdice bdice self-assigned this Jun 2, 2023
@bdice bdice changed the base branch from branch-23.06 to branch-23.08 June 2, 2023 19:41
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 2, 2023
@bdice
Copy link
Contributor Author

bdice commented Jun 2, 2023

/merge

@rapids-bot rapids-bot bot merged commit 01513ed into rapidsai:branch-23.08 Jun 2, 2023
@bdice bdice deleted the fix-test-deprecations branch June 2, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants