Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build dependencies #5496

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Update build dependencies #5496

merged 3 commits into from
Jul 11, 2023

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Jul 10, 2023 •
edited
Loading

Add missing build dependencies: gtest, gmock, and nvcc.

Likely not noticed previously because of an implicit dependency.

@csadorf
Add gtest to common_build dependencies.
6019606 
Needed by default unless the --nolibcumltest option is provided to the
build.sh script.
@csadorf
Add nvcc to common_build dependencies.
ec724b3
@csadorf csadorf requested a review from a team as a code owner July 10, 2023 19:32
@github-actions github-actions bot added the conda conda issue label Jul 10, 2023
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 10, 2023
@csadorf csadorf mentioned this pull request Jul 10, 2023
Merged
2 tasks
@csadorf csadorf self-assigned this Jul 10, 2023
@csadorf
Copy link
Contributor Author

csadorf commented Jul 10, 2023

/merge

@rapids-bot rapids-bot bot merged commit 090ce41 into rapidsai:branch-23.08 Jul 11, 2023
@csadorf csadorf deleted the enh-update-build-dependencies branch July 11, 2023 14:53
rapids-bot bot pushed a commit that referenced this pull request Jul 13, 2023
@csadorf
CI: Add custom GitHub Actions job to run clang-tidy (#5235)
3e59b65 
Follow-up from #4983 ; should be merged after that.

- [x] Adjust clang-tidy script to only run CMAKE to generate the compile-commands db and not to actually build.
- [x] #5496

Authors:
  - Simon Adorf (https://github.com/csadorf)
  - Bradley Dice (https://github.com/bdice)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@raydouglass raydouglass raydouglass approved these changes

Assignees

@csadorf csadorf

Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csadorf @raydouglass @bdice