Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using setup.py in build.sh #5500

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Stop using setup.py in build.sh #5500

merged 1 commit into from
Jul 13, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jul 12, 2023

This PR changes replaces direct invocations of setup.py in build.sh with pip install commands since setup.py usage is deprecated. This change will facilitate upcoming changes to our build systems.

@vyasr vyasr added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 12, 2023
@vyasr vyasr self-assigned this Jul 12, 2023
@vyasr vyasr requested a review from a team as a code owner July 12, 2023 20:06
dantegd
dantegd reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantegd
Copy link
Member

dantegd commented Jul 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit a085828 into rapidsai:branch-23.08 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @dantegd