Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable wheels CI scripts to run locally #5507

Merged
merged 26 commits into from
Jul 25, 2023
Merged

Enable wheels CI scripts to run locally #5507

merged 26 commits into from
Jul 25, 2023

Conversation

divyegala
Copy link
Member

No description provided.

@divyegala divyegala added feature request New feature or request non-breaking Non-breaking change labels Jul 18, 2023
@github-actions github-actions bot added the ci label Jul 18, 2023
vyasr
vyasr reviewed Jul 18, 2023
View reviewed changes
ci/build_wheel.sh Outdated Show resolved Hide resolved
vyasr
vyasr reviewed Jul 18, 2023
View reviewed changes
ci/build_wheel.sh Outdated Show resolved Hide resolved
vyasr
vyasr reviewed Jul 18, 2023
View reviewed changes
ci/build_wheel.sh Outdated Show resolved Hide resolved
vyasr
vyasr approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update workflow names, and one question about default script. Otherwise good to go.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/pr.yaml Outdated Show resolved Hide resolved
@divyegala divyegala marked this pull request as ready for review July 24, 2023 20:18
@divyegala divyegala requested a review from a team as a code owner July 24, 2023 20:18
@divyegala divyegala added improvement Improvement / enhancement to an existing function and removed feature request New feature or request labels Jul 24, 2023
ajschmidt8
ajschmidt8 reviewed Jul 24, 2023
View reviewed changes
ci/build_wheel.sh Outdated Show resolved Hide resolved
ci/build_wheel.sh Outdated Show resolved Hide resolved
divyegala and others added 3 commits July 24, 2023 18:17
@divyegala @ajschmidt8
Apply suggestions from code review
f2e95b7 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@divyegala
merge upstream
3f46af0
@divyegala
fix bad merge
7e464d0
@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b2a781f into rapidsai:branch-23.08 Jul 25, 2023
@jakirkham jakirkham mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @vyasr @ajschmidt8