Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused matrix.cuh and math.cuh headers to eliminate deprecation warnings. #5513

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 21, 2023

This PR addresses part of #5510. There are several places in libcuml where deprecated RAFT headers are included but unused. This PR reduces the inclusions of raft/matrix/matrix.cuh and raft/matrix/math.cuh so that fewer warnings appear (only when the deprecated headers are actually used).

@bdice bdice added Tech Debt Issues related to debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 21, 2023
@bdice bdice requested a review from a team as a code owner July 21, 2023 15:14
@bdice bdice self-assigned this Jul 21, 2023
@divyegala
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e310957 into rapidsai:branch-23.08 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Tech Debt Issues related to debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants