Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample_weight parameter to dbscan.fit #5574

Merged
merged 8 commits into from
Sep 28, 2023

Conversation

mfoerste4
Copy link
Contributor

This PR adds the optional 'sample_weight' parameter to the dbscan fit function.
Issue: #5556

CC @tfeher

@mfoerste4 mfoerste4 requested review from a team as code owners September 6, 2023 14:25
@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels Sep 6, 2023
@dantegd dantegd added the 3 - Ready for Review Ready for review by team label Sep 25, 2023
@tfeher tfeher added feature request New feature or request non-breaking Non-breaking change breaking Breaking change and removed non-breaking Non-breaking change labels Sep 27, 2023
@tfeher
Copy link
Contributor

tfeher commented Sep 27, 2023

This PR is non breaking for the Python API, and breaking for C++ API. I have added the "breaking" label.

Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfoerste4 for the clean implementation! The PR looks good to me!

@dantegd
Copy link
Member

dantegd commented Sep 28, 2023

/merge

@rapids-bot rapids-bot bot merged commit a515624 into rapidsai:branch-23.10 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants