-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multiclass svm for sparse input #5588
Enable multiclass svm for sparse input #5588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Malte for the PR, it looks good overall. Just one question about testing: do we have only the pickle test for this feature? If yes, could we improve coverage in test_svm.py
?
@tfeher , I extended an existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one request, otherwise looks good. Make sure to update the base branch to branch-23.12
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mfoerste4 for adding the test! Apart from the last open question about the helper placement the PR looks good to me!
@csadorf, I believe the failing CI checks are unrelated to this PR. Could you have a look at the changes requested? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/merge |
@mfoerste4 @tfeher I think the |
@mfoerste4 Thanks for the fix. Tests are currently expected to fail because of an upstream incompatibility between raft and rmm. |
@csadorf , I was not able to reproduce the issue locally, I just hope it is a duplicate of the bug that i came across yesterday. |
This commit enables multiclass SVM for sparse input. Previously this was deactivated as the
input_to_host_array
functionality does not support sparse arrays, but the data has to be piped through sklearn classes which requires host data.@dantegd , this is a local workaround to enable a
input_to_host_array
for sparse data without the complexity of providing the whole functionality of that function. Please have a look whether this is an acceptable solution for this use case.FYI, @tfeher