Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accidental unsafe cupy import #5613

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix accidental unsafe cupy import #5613

merged 1 commit into from
Oct 9, 2023

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Oct 9, 2023

PR fixes an accidental unsafe cupy import from a recent PR. Tests to detect these will be added in 23.12.

@dantegd dantegd requested a review from a team as a code owner October 9, 2023 04:19
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dantegd dantegd changed the base branch from branch-23.12 to branch-23.10 October 9, 2023 04:19
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 9, 2023
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Oct 9, 2023
@raydouglass raydouglass merged commit 6bd3842 into rapidsai:branch-23.10 Oct 9, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantegd @raydouglass @wphicks