Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rich HTML representation to estimators #5630

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

betatim
Copy link
Member

@betatim betatim commented Oct 26, 2023

This adds a Jupyter (and other notebook) rich display hook that produces a HTML widget to represent an estimator in notebooks.

This adds the basics of having estimators displayed as HTML widgets in notebooks and other editors that use the Jupyter notebook "rich display" system.

Screenshot 2023-10-26 at 15 33 37

This doesn't yet contain the cool feature of changing colour depending on fit status or the link to the documentation. For that we'd have to depend on a newer version of scikit-learn (or vendor the logic). In this case "newer" actually means "the next version to be released".

WDYT?

This adds a Jupyter (and other notebook) rich display hook that produces
a HTML widget to represent an estimator in notebooks.
@betatim betatim requested a review from a team as a code owner October 26, 2023 14:26
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 26, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 26, 2023
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 26, 2023
@csadorf
Copy link
Contributor

csadorf commented Oct 30, 2023

/ok to test

@dantegd
Copy link
Member

dantegd commented Oct 31, 2023

/ok to test

@csadorf csadorf added the 3 - Ready for Review Ready for review by team label Nov 8, 2023
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this one our notebooks and it seems to work!

@csadorf
Copy link
Contributor

csadorf commented Nov 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9fed69e into rapidsai:branch-23.12 Nov 9, 2023
52 checks passed
@betatim betatim deleted the html-repr branch November 13, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants