[LogisticRegressionMG] Support sparse vectors #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lijinf2
force-pushed
the
fea_lrmg_sparse
branch
from
a838ac8 to
92d4084
Compare
lijinf2
added
improvement
lijinf2
force-pushed
the
fea_lrmg_sparse
branch
2 times, most recently
from
f033c56 to
5d29871
Compare
…ently calculated reg_loss
…oducible when running test_dask_base.py with 2 GPUs
lijinf2
force-pushed
the
fea_lrmg_sparse
branch
from
5d29871 to
22e90fe
Compare
cjnolet
requested changes
Nov 27, 2023
| @@ -63,6 +63,22 @@ void qnFit(raft::handle_t& handle, | |||
| float* f, | |||
| int* num_iters); | |||
|
|
|||
| /** | |||
| * TODO: add docstring | |||
There was a problem hiding this comment.
This is part of the public API so we should add a docstring here.
There was a problem hiding this comment.
Thanks for helping review the PR. Just added the docstring.
| @pytest.mark.parametrize("dtype", [np.float32]) | ||
| def test_sparse_nlp20news(dtype, nlp_20news, client): | ||
| # sklearn score with max_iter = 10000 | ||
| sklearn_score = 0.878 |
There was a problem hiding this comment.
This could become a maintenance nightmare should sklearn ever get updated. Any reason we can't just compute this in the test?
There was a problem hiding this comment.
Sounds Good! Just revised the test test to compute sklearn accuracy in the test.
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…ly one class (#5655) This pull request introduces functionality for C++ training on datasets with a single label. It helps Spark Rapids ML match Spark's behavior. Additionally, it updates the Dask class to generate an error message, consistent with Scikit-learn's behavior. This PR depends on #5632 Authors: - Jinfeng Li (https://github.com/lijinf2) Approvers: - Simon Adorf (https://github.com/csadorf) - Corey J. Nolet (https://github.com/cjnolet) URL: #5655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.