Use drop_duplicates instead of unique for cudf's pandas compatibility mode #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
csadorf
approved these changes
Nov 3, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
I accidentally committed but forgot to push some changes requested by @csadorf in #5639. Authors: - Vyas Ramasubramani (https://github.com/vyasr) - Simon Adorf (https://github.com/csadorf) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #5648
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pandas,
Series.uniquereturns a numpy array (for non-extension types) whileSeries.drop_duplicatesreturns aSeries. The two results should otherwise contain the same set of values. In cudf, historically both methods returned aSeries, and at these stages in cuml's pipeline it knows that it is working with cudf objects. However, if cudf has pandas compatibility mode enabled, thenuniquewill return an array to match pandas behavior. In this scenario, the method chaining no longer works because cupy is calling methods on the result ofuniqueassuming that it will be aSeries. To fix this, cuml needs to calldrop_duplicatesinstead.