Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move _process_generic to base_return_types, avoid circular import #5695

Merged
merged 3 commits into from
Dec 12, 2023
Merged

move _process_generic to base_return_types, avoid circular import #5695

merged 3 commits into from
Dec 12, 2023

Conversation

dcolinmorgan
Copy link
Contributor

No description provided.

@dcolinmorgan dcolinmorgan requested a review from a team as a code owner December 11, 2023 07:05
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 11, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 11, 2023
@dcolinmorgan dcolinmorgan marked this pull request as draft December 11, 2023 07:05
@dcolinmorgan dcolinmorgan marked this pull request as ready for review December 11, 2023 07:07
@dcolinmorgan dcolinmorgan mentioned this pull request Dec 11, 2023
Open
@dcolinmorgan dcolinmorgan marked this pull request as draft December 11, 2023 07:24
@dcolinmorgan dcolinmorgan marked this pull request as ready for review December 11, 2023 07:25
@wphicks wphicks added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 11, 2023
@wphicks
Copy link
Contributor

wphicks commented Dec 11, 2023

/ok to test

@wphicks
Copy link
Contributor

wphicks commented Dec 11, 2023

@dcolinmorgan Very nice, thank you! I don't see any reason not to make that move, and it's a great start on our circular import woes in the base infrastructure. I've triggered CI and will approve as soon as I see it go green.

@wphicks
Copy link
Contributor

wphicks commented Dec 12, 2023

/ok to test

@wphicks
Copy link
Contributor

wphicks commented Dec 12, 2023

/merge

@rapids-bot rapids-bot bot merged commit 3dfdb6e into rapidsai:branch-24.02 Dec 12, 2023
54 checks passed
@dcolinmorgan
Copy link
Contributor Author

dcolinmorgan commented Dec 12, 2023 •
edited
Loading

Thanks @wphicks. I realized I should've checked out v23.10 for this. can you backport it or I can push more to this PR.

This was referenced Dec 13, 2023
Closed
Closed
@wphicks
Copy link
Contributor

wphicks commented Dec 13, 2023

can you backport it

Unfortunately, as I mentioned on the other PR, I don't think this warrants a backport, especially two versions back. If you're locked into using 23.10 for some reason, feel free to open an issue or reach out on Slack and we can see if we can help you find a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcolinmorgan @wphicks