Mark all kernels with internal linkage #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
reviewed
Feb 7, 2024
No, will revise to use a common macro |
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
from
5f730c2 to
53d3d0b
Compare
robertmaynard
force-pushed
the
fea/mark_kernels_as_internal
branch
from
53d3d0b to
c33e56b
Compare
bdice
reviewed
Apr 10, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Apr 10, 2024
bdice
reviewed
Apr 12, 2024
|
This should be good to go once the documentation fix finishes running CI and we get an ops approval. I'll pre-emptively merge this. |
|
/merge |
raydouglass
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream consumers of static built versions of RAPIDS C++ projects have encountered runtime issues due to multiple instances of the same kernel existing in different DSOs.
To resolve this issue we need to ensure that all CUDA kernels in all RAPIDS libraries need to be have internal linkage ( static for projects using whole compilation, attribute((visibility("hidden"))) for header libraries / separable compilation ).
This updates all cuml kernels to have internal linkage, and adds a CI job to verify that no new kernels are added with external linkage.