Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Let cuDF handle input types for label encoder. #5783

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

trivialfis
Copy link
Member

cuDF handles more types than the label encoder currently does (like torch tensor). This PR delegates the type checking to cuDF.

  • Let cuDF handle input types for label encoder.
  • Small cleanups.

cuDF handles more types than the label encoder currently does (like torch tensor). This PR
delegates the type checking to cuDF.

- Let cuDF handle input types for label encoder.
- Small cleanups.
@trivialfis trivialfis added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2024
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 23, 2024
@trivialfis trivialfis marked this pull request as ready for review February 26, 2024 07:23
@trivialfis trivialfis requested a review from a team as a code owner February 26, 2024 07:23
@trivialfis trivialfis added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Feb 26, 2024
@dantegd
Copy link
Member

dantegd commented Mar 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit e3b898f into rapidsai:branch-24.04 Mar 4, 2024
62 checks passed
@trivialfis trivialfis deleted the labelencoder-series branch March 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants