Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding of RAPIDS version where possible #5793

Merged
merged 8 commits into from
Mar 8, 2024
Merged

Remove hard-coding of RAPIDS version where possible #5793

merged 8 commits into from
Mar 8, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

  • Read VERSION file from CMake
  • Read cuml.__version__ from docs build
  • Read VERSION file from ci/build_docs.sh

Issue: rapidsai/build-planning#15

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 5, 2024 15:47
@KyleFromNVIDIA KyleFromNVIDIA added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 5, 2024
robertmaynard
robertmaynard reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci/release/update-version.sh can drop the sed logic for updating the CMakeLists.txt

@KyleFromNVIDIA
Copy link
Contributor Author

ci/release/update-version.sh can drop the sed logic for updating the CMakeLists.txt

Will update once this round of CI is finished.

@jakirkham
Copy link
Member

Thanks Kyle! 🙏

Think we can also make these changes: rapidsai/build-planning#15 (comment) + rapidsai/build-planning#15 (comment)

@KyleFromNVIDIA
Copy link
Contributor Author

It seems that cuml is already using that approach:

cuml/python/pyproject.toml

Line 48 in 73e04e2

dynamic = ["version"]

@KyleFromNVIDIA KyleFromNVIDIA added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 2 - In Progress Currenty a work in progress labels Mar 6, 2024
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner March 7, 2024 15:56
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit dc66ff9 into rapidsai:branch-24.04 Mar 8, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond ci CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleFromNVIDIA @jakirkham @robertmaynard @bdice @AyodeAwe