Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound to prevent usage of NumPy 2 #5797

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 12, 2024

NumPy 2 is expected to be released in the near future. For the RAPIDS 24.04 release, we will pin to numpy>=1.23,<2.0a0. This PR adds an upper bound to affected RAPIDS repositories.

xref: rapidsai/build-planning#29

@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 12, 2024
@github-actions github-actions bot added the conda conda issue label Mar 12, 2024
@bdice bdice marked this pull request as ready for review March 12, 2024 22:34
@bdice bdice requested a review from a team as a code owner March 12, 2024 22:34
@bdice
Copy link
Contributor Author

bdice commented Mar 13, 2024

/merge

@jakirkham
Copy link
Member

jakirkham commented Mar 13, 2024

Restarted CI as it looked like there were some flaky tests

@bdice
Copy link
Contributor Author

bdice commented Mar 13, 2024

Reran CI again, but it has failed several times. 😕

@raydouglass raydouglass merged commit f80035d into rapidsai:branch-24.04 Mar 14, 2024
54 of 59 checks passed
@jakirkham
Copy link
Member

Think the failure is legitimate, but don't think it is related to this pinning. See it even on nightly builds

Raised issue: #5803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants