Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct and adjust tolerances of mnmg logreg pytests #5812

Merged
merged 7 commits into from
Apr 4, 2024
Merged

Correct and adjust tolerances of mnmg logreg pytests #5812

merged 7 commits into from
Apr 4, 2024

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Mar 20, 2024

No description provided.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 20, 2024
@dantegd dantegd added bug Something isn't working tests Unit testing for project non-breaking Non-breaking change labels Mar 20, 2024
@dantegd dantegd marked this pull request as ready for review April 3, 2024 15:55
@dantegd dantegd requested a review from a team as a code owner April 3, 2024 15:55
bdice
bdice approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM. It seems there are some CI failures, but I haven't looked at them.

@raydouglass raydouglass merged commit b9e4a60 into rapidsai:branch-24.04 Apr 4, 2024
56 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantegd @bdice @wphicks @raydouglass