Support expression-based Dask Dataframe API #5835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
rjzamora
changed the title
… dask-cudf now" This reverts commit 04420af.
pentschev
suggested changes
Apr 10, 2024
Co-authored-by: Peter Andreas Entschev <peter@entschev.com>
bdice
approved these changes
Apr 10, 2024
galipremsagar
approved these changes
Apr 10, 2024
AyodeAwe
approved these changes
Apr 10, 2024
pentschev
approved these changes
Apr 10, 2024
|
/merge |
Closed
|
Thanks all! 🙏 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
Fixes some leftover `dask_cudf.core` imports missed in #5835. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Richard (Rick) Zamora (https://github.com/rjzamora) - Dante Gama Dessavre (https://github.com/dantegd) URL: #5874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves current/recent CI failures related to dask-expr migration in
dask.dataframe/dask_cudf.Notes:
dask_cudf.corefor instance checks. Types should be imported from the top-leveldask_cudfpackage to ensure the proper API (legacy vs dask-expr) is used.kneighbors_classifierfailures are caused by Incorrectuniqueresult for column with numerical name dask/dask-expr#1015 - The temporary workaround is to convertyto a legacy collection in this particular case.