Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove return in test_lbfgs #5875

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Remove return in test_lbfgs #5875

merged 5 commits into from
Apr 30, 2024

Conversation

mroeschke
Copy link
Contributor

Similar to #5819, pytest functions should not return and seems unneeded in this test

@mroeschke mroeschke requested a review from a team as a code owner April 29, 2024 20:50
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 29, 2024
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 29, 2024
@dantegd
Copy link
Member

dantegd commented Apr 29, 2024

/merge

@mroeschke
Copy link
Contributor Author

Turns out the return was needed, but made the method "private" to avoid the pytest warning

@rapids-bot rapids-bot bot merged commit 89d5371 into rapidsai:branch-24.06 Apr 30, 2024
60 checks passed
@mroeschke mroeschke deleted the test/pytest/return branch April 30, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @dantegd @bdice