Enable pytest failures on FutureWarnings/DeprecationWarnings #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
tests
dantegd
approved these changes
May 1, 2024
There was a problem hiding this comment.
PR looks great, thanks for the help @mroeschke! Very excited to merge this
python/pyproject.toml
Outdated
| "error:::cudf", | ||
| "ignore:[^.]*ABCs[^.]*:DeprecationWarning:patsy[.*]", | ||
| "ignore:(.*)alias(.*):DeprecationWarning:hdbscan[.*]", | ||
| # TODO |
There was a problem hiding this comment.
Can we open a GH issue with the content of this file there? Will be great to track tackling these.
mroeschke
commented
May 1, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite will now fail on FutureWarnings and DeprecationWarnings as apart of rapidsai/build-planning#26.
pytest.ini was consolidated into pyproject.toml so there's only 1 place with these configs.
There are some
TODOs including scikit-learn warnings, but I hope it's OK to potentially pass the baton to @betatim :)