Allow estimators to accept any dtype #5888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
feature request
divyegala
reviewed
Jul 29, 2024
| I_ndarr = cuml.common.input_to_cuml_array(I_cparr).array | ||
| I_ndarr = cuml.common.input_to_cuml_array( | ||
| I_cparr, | ||
| convert_to_dtype=(np.float32 if convert_dtype |
There was a problem hiding this comment.
This looks incorrect. Default should be np.int32 or np.int64, I'm not sure what the API accepts
There was a problem hiding this comment.
good catch, this should be int64
Co-authored-by: Divye Gala <divyegala@gmail.com>
divyegala
approved these changes
Jul 29, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4477
Adds the capability for all estimators to accept any dtype by converting the inputs if needed to. Currently, for most estimators, this means converting to float32.
Todo:
cc @beckernick @pentschev @isVoid @divyegala