Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RandomForestClassifier return type #5896

Merged
merged 3 commits into from
May 23, 2024
Merged

Fix RandomForestClassifier return type #5896

merged 3 commits into from
May 23, 2024

Conversation

jinsolp
Copy link
Contributor

@jinsolp jinsolp commented May 17, 2024

Closes #5637

import cuml
from cuml.datasets import make_classification

X, y = make_classification()

clf = cuml.ensemble.RandomForestClassifier().fit(X,y)
print(clf.predict(X[:5]).dtype)

Result is

int64

@jinsolp jinsolp requested a review from a team as a code owner May 17, 2024 23:12
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 17, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 17, 2024
dantegd
dantegd approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks good to me

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels May 22, 2024
@dantegd
Copy link
Member

dantegd commented May 22, 2024

/ok to test

@dantegd
Copy link
Member

dantegd commented May 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 47416d7 into rapidsai:branch-24.06 May 23, 2024
60 of 63 checks passed
@jinsolp jinsolp deleted the fix-rfclassifier-float branch May 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
2 participants
@jinsolp @dantegd