Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] PCA Initialization for TSNE #5897

Merged
merged 24 commits into from
Jul 10, 2024
Merged

[FEA] PCA Initialization for TSNE #5897

merged 24 commits into from
Jul 10, 2024

Conversation

aamijar
Copy link
Contributor

@aamijar aamijar commented May 19, 2024

Closes #3458

Add PCA embedding initialization to C++ layer and expose it in Python API.

from cuml.manifold import TSNE

tsne = TSNE(
    ...
    init="pca" # ("random" or "pca")
)

@aamijar aamijar requested review from a team as code owners May 19, 2024 05:42
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels May 19, 2024
@cjnolet
Copy link
Member

cjnolet commented May 19, 2024

/ok to test

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 19, 2024
cjnolet
cjnolet requested changes May 20, 2024
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! This is a long needed feature, so really happy to have it in.

cpp/include/cuml/manifold/tsne.h Outdated Show resolved Hide resolved
cpp/src/tsne/tsne_runner.cuh Outdated Show resolved Hide resolved
python/cuml/manifold/t_sne.pyx Outdated Show resolved Hide resolved
cpp/src/tsne/barnes_hut_tsne.cuh Outdated Show resolved Hide resolved
python/cuml/manifold/t_sne.pyx Outdated Show resolved Hide resolved
lowener
lowener reviewed May 30, 2024
View reviewed changes
cpp/src/tsne/tsne_runner.cuh Outdated Show resolved Hide resolved
cpp/src/tsne/tsne_runner.cuh Outdated Show resolved Hide resolved
cpp/test/sg/tsne_test.cu Outdated Show resolved Hide resolved
cpp/test/sg/tsne_test.cu Outdated Show resolved Hide resolved
cpp/test/sg/tsne_test.cu Outdated Show resolved Hide resolved
@aamijar aamijar force-pushed the pca-init-for-tsne branch from 69b9d42 to f57129a Compare May 31, 2024 22:25
@aamijar aamijar changed the base branch from branch-24.06 to branch-24.08 May 31, 2024 23:01
@aamijar aamijar requested review from a team as code owners May 31, 2024 23:01
@aamijar aamijar changed the base branch from branch-24.08 to branch-24.06 May 31, 2024 23:02
@github-actions github-actions bot added conda conda issue ci labels May 31, 2024
@aamijar aamijar changed the base branch from branch-24.06 to branch-24.08 May 31, 2024 23:24
@aamijar aamijar changed the base branch from branch-24.08 to branch-24.06 May 31, 2024 23:26
@dantegd dantegd changed the base branch from branch-24.06 to branch-24.08 June 1, 2024 01:18
@dantegd
Copy link
Member

dantegd commented Jun 1, 2024

@aamijar the git diff will be fixed once #5911 is merged

@github-actions github-actions bot removed the ci label Jun 3, 2024
@dantegd
Copy link
Member

dantegd commented Jun 7, 2024

/ok to test

@dantegd
Copy link
Member

dantegd commented Jun 11, 2024

/ok to test

@dantegd
Copy link
Member

dantegd commented Jun 12, 2024

/ok to test

@dantegd
Copy link
Member

dantegd commented Jun 13, 2024

/ok to test

@dantegd dantegd requested a review from cjnolet June 14, 2024 23:12
lowener
lowener requested changes Jun 17, 2024
View reviewed changes
python/cuml/tests/test_tsne.py Outdated Show resolved Hide resolved
cpp/test/sg/tsne_test.cu Show resolved Hide resolved
@aamijar aamijar requested a review from lowener June 18, 2024 05:23
@dantegd
Copy link
Member

dantegd commented Jun 25, 2024

/ok to test

1 similar comment
@lowener
Copy link
Contributor

lowener commented Jun 26, 2024

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Jun 28, 2024

/ok to test

@lowener
Copy link
Contributor

lowener commented Jul 5, 2024

/ok to test

@lowener
Copy link
Contributor

lowener commented Jul 9, 2024

/ok to test

@lowener
Copy link
Contributor

lowener commented Jul 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1e7de60 into rapidsai:branch-24.08 Jul 10, 2024
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala left review comments

@lowener lowener lowener approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] PCA initialization for TSNE
5 participants
@aamijar @cjnolet @dantegd @lowener @divyegala