Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support double precision in MNMG Logistic Regression #5898

Merged
merged 6 commits into from
May 22, 2024
Merged

Support double precision in MNMG Logistic Regression #5898

merged 6 commits into from
May 22, 2024

Conversation

lijinf2
Copy link
Contributor

@lijinf2 lijinf2 commented May 20, 2024

Github issue: #5589

@lijinf2 lijinf2 requested review from a team as code owners May 20, 2024 05:41
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented May 20, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels May 20, 2024
@lijinf2 lijinf2 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 20, 2024
@lijinf2 lijinf2 force-pushed the fea_lrmg_double branch from 428ce45 to 648efd4 Compare May 20, 2024 06:03
@cjnolet
Copy link
Member

cjnolet commented May 20, 2024

/ok to test

lijinf2 added 5 commits May 20, 2024 19:27
@lijinf2
get getUniqueLabelsMG working
f3a32cb 
Signed-off-by: jinfengli <jinfengl@nvidia.com>
Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2
get qnFit ready
598a828 
Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2
get qnFitSparse ready
0476799 
Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2
improve tests to cover float64
b7c41df 
Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2
get pre-commit passed
36bb820 
Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2 lijinf2 force-pushed the fea_lrmg_double branch from 648efd4 to 2401f36 Compare May 20, 2024 19:28
@lijinf2
add float64 to more tests
ba3dfc4 
Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2 lijinf2 force-pushed the fea_lrmg_double branch from 2401f36 to ba3dfc4 Compare May 20, 2024 19:39
dantegd
dantegd approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, glad it seems like everything was straightforward

@dantegd
Copy link
Member

dantegd commented May 22, 2024

/merge

@rapids-bot rapids-bot bot merged commit f16fccc into rapidsai:branch-24.06 May 22, 2024
60 of 63 checks passed
@lijinf2 lijinf2 deleted the fea_lrmg_double branch September 18, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lijinf2 @cjnolet @dantegd