Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Treelite to 4.2.1 #5908

Merged
merged 5 commits into from
Jun 15, 2024
Merged

Bump Treelite to 4.2.1 #5908

merged 5 commits into from
Jun 15, 2024

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented May 28, 2024

Treelite 4.2.1 contains the following improvements:

@hcho3 hcho3 requested review from a team as code owners May 28, 2024 23:44
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels May 28, 2024
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels May 28, 2024
bdice
bdice approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dantegd dantegd changed the base branch from branch-24.06 to branch-24.08 June 3, 2024 23:34
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels Jun 5, 2024
@dantegd
Copy link
Member

dantegd commented Jun 12, 2024

@hcho3 seems like the RAPIDS dependency file generator CI check failed, I think it should be the only thing blocking the PR, could you fix it?

@hcho3 hcho3 requested a review from a team as a code owner June 12, 2024 03:54
@hcho3 hcho3 requested a review from jameslamb June 12, 2024 03:54
jameslamb
jameslamb approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this so you don't have to wait for me to merge it, but please do run pre-commit run --all-files to fix the CI issue from rapids-dependency-file-generator.

@dantegd
Copy link
Member

dantegd commented Jun 14, 2024

@hcho3 seems like there is still an issue with missing committing the results from the rapids-file-generator precommit

@hcho3
Copy link
Contributor Author

hcho3 commented Jun 15, 2024

My bad. Forgot to push the commit.

@dantegd
Copy link
Member

dantegd commented Jun 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit 205748c into rapidsai:branch-24.08 Jun 15, 2024
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@bdice bdice bdice approved these changes

@raydouglass raydouglass raydouglass approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hcho3 @dantegd @raydouglass @bdice @jameslamb