Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposes:
hdbscan
from PyPI instead of GitHubrapids-dependency-file-generator --output requirements
generates a full set of test dependenciesBenefits of these changes
cuml
's test dependenciesNotes for Reviewers
I tried testing a
devcontainers
change today (rapidsai/devcontainers#325), like this:Found that the
cuml
unit tests failed immediately with an error complaining abouthdbscan
not being available. Looks like that's because it's used unconditionally here:cuml/python/cuml/tests/test_hdbscan.py
Line 20 in 6342914
This hasn't shown up in CI because in CI, the
cuml
wheel's[test]
extra is used to figure out what dependencies to install:cuml/ci/test_wheel.sh
Line 16 in 6342914
But RAPIDS devcontainers use
rapids-dependency-file-generator --output requirements
:https://github.com/rapidsai/devcontainers/blob/0ec3cbd47af5ffdc1399af2cb9e33e34617230c3/features/src/rapids-build-utils/opt/rapids-build-utils/bin/make-pip-dependencies.sh#L90-L96