Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for benchmark runner to handle parameter sweeps of multiple data types #5938

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix for benchmark runner to handle parameter sweeps of multiple data types #5938

merged 2 commits into from
Jun 24, 2024

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jun 16, 2024 •
edited
Loading

PR fixes parameter sweeps of benchmarks when they have a different type, so for example:

--cuml-param-sweep init=random,scalable-k-means++

@dantegd dantegd changed the title Fix for benchmark runner to handle parameter sweeps of multiple d… Fix for benchmark runner to handle parameter sweeps of multiple data types Jun 16, 2024
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jun 16, 2024
@dantegd dantegd marked this pull request as ready for review June 17, 2024 19:39
@dantegd dantegd requested a review from a team as a code owner June 17, 2024 19:39
@dantegd
Copy link
Member Author

dantegd commented Jun 17, 2024

/merge

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Jun 24, 2024
@rapids-bot rapids-bot bot merged commit 751ba82 into rapidsai:branch-24.08 Jun 24, 2024
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantegd @divyegala