Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fix: use ld_preload to avoid libgomp issue on ARM jobs #5949

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jul 2, 2024

No description provided.

@github-actions github-actions bot added the ci label Jul 2, 2024
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Jul 2, 2024
@msarahan
Copy link
Contributor

msarahan commented Jul 2, 2024

This makes me uncomfortable as a fix. It is essentially saying "I know that the base environment libgomp is already loaded, so let me ignore the one in my test environment." This kind of seems like conforming to insanity.

I think a better approach might be to figure out why the base environment libgomp is being loaded. Is the test environment activated? If so, does something have bad RPATH stuff? Are libraries being loaded with dlopen anywhere? This is more like saying what sanity is, then figuring out why things are not sane.

@dantegd
Copy link
Member Author

dantegd commented Jul 2, 2024

@msarahan you raise a point that is more user error (i.e. mine) than something wrong in the environment, I used the base env libgomp.so by error, I changed it to the libgomp.so in the environment which should be the correct one.

@dantegd
Copy link
Member Author

dantegd commented Jul 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2830e87 into rapidsai:branch-24.08 Jul 4, 2024
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants