Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename .devcontainers for CUDA 12.5 #5967

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Rename .devcontainers for CUDA 12.5 #5967

merged 1 commit into from
Jul 17, 2024

Conversation

jakirkham
Copy link
Member

Follow up to PR: #5963
Partially addresses issue: rapidsai/build-planning#73

Renames the .devcontainers for CUDA 12.5

cc @KyleFromNVIDIA @jameslamb @trxcllnt (for awareness)

@jakirkham jakirkham requested a review from a team as a code owner July 16, 2024 22:16
@jakirkham jakirkham requested a review from AyodeAwe July 16, 2024 22:16
@jakirkham jakirkham added bug Something isn't working non-breaking Non-breaking change labels Jul 16, 2024
@jakirkham
Copy link
Member Author

The optional-job-conda-python-tests-cudf-pandas-integration jobs failed. Seeing some memory errors amongst other things in there. Trying to restart to see if that clears up the issue. If not, we may want to ask someone more familiar with these tests to take a closer look

@dantegd
Copy link
Member

dantegd commented Jul 17, 2024 •
edited
Loading

@jakirkham the optional-job-conda-python-tests-cudf-pandas-integratio are optional and not needed to pass right now, do not restart the run for those jobs.

@jakirkham
Copy link
Member Author

Ah ok. Will ignore them. Thanks Dante! 🙏

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 99b20f6 into rapidsai:branch-24.08 Jul 17, 2024
60 of 62 checks passed
@jakirkham jakirkham deleted the rename_devcont_12.5 branch July 17, 2024 17:24
@jakirkham
Copy link
Member Author

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakirkham @dantegd @trxcllnt @jameslamb