BUG: remove sample parameter from pca call to mean #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfoerste4
added
bug
bdice
approved these changes
Jul 25, 2024
dantegd
approved these changes
Jul 25, 2024
|
/merge |
cjnolet
approved these changes
Jul 25, 2024
|
The reason why these issues did not result in failures before is that the sample parameter was silently ignored for column based data in raft. Now that behavior was fixed in rapidsai/raft#2381 which now reveals issues downstream. |
|
/merge |
jameslamb
pushed a commit
to jameslamb/cuml
that referenced
this pull request
Jul 26, 2024
This fixes a call to `raft::stats::mean()` deactivating the sample parameter in the pca code. CC @dantegd Authors: - Malte Förster (https://github.com/mfoerste4) Approvers: - Bradley Dice (https://github.com/bdice) - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#5980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a call to
raft::stats::mean()deactivating the sample parameter in the pca code.CC @dantegd