-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for XGBoost UBJSON in FIL #6009
Add support for XGBoost UBJSON in FIL #6009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and this fixes things perfectly for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! I did not try re-running the notebook yet, but I trust that this works.
Won't block the PR over this since this is time-sensitive for the release... but I think we should have some unit tests covering these new if-else branches, to detect such issues earlier in the future. I'd be happy to do that on 24.10 if you'd like, would be a good opportunity for me to learn a little more about FIL.
Oh wait.... doesn't the notebook need to be updated? Here it's saying cuml/notebooks/forest_inference_demo.ipynb Line 278 in 50d1a74
But I think cross-ref: rapidsai/docker#699 |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Closes #6008