[FEA] UMAP API for building with batched NN Descent #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinsolp
added
improvement
|
Will change |
dantegd
requested changes
Aug 21, 2024
cjnolet
approved these changes
Aug 22, 2024
cpp/cmake/thirdparty/get_raft.cmake
Outdated
| @@ -82,8 +82,8 @@ endfunction() | |||
| # To use a different RAFT locally, set the CMake variable | |||
| # CPM_raft_SOURCE=/path/to/local/raft | |||
| find_and_configure_raft(VERSION ${CUML_MIN_VERSION_raft} | |||
| FORK rapidsai | |||
| PINNED_TAG branch-${CUML_BRANCH_VERSION_raft} | |||
| FORK jinsolp | |||
There was a problem hiding this comment.
Just a reminder this needs to be reverted before this PR is merged
There was a problem hiding this comment.
Yep! I'll revert these after the raft PR is merged the package is released : )
dantegd
approved these changes
Aug 23, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds the following parameters as part of the
build_kwdsn_clusters: number of clusters to use when batching. Larger number of clusters reduce GPU memory usage. Defaults to 1 (no batch)Results showing consistent trustworthiness scores for doing/not doing batching.
Also note below that now UMAP can run with datasets that don't fit on the GPU. Putting the dataset on host and enabling the batching method allows UMAP to run with a dataset that is 50M x 768 (153GB).
Notes
This PR in raft needs to be merged before this PR