Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for simplicial_set_embedding #6043

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Fix for simplicial_set_embedding #6043

merged 10 commits into from
Sep 11, 2024

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Aug 22, 2024 •
edited by divyegala
Loading

Closes #6041 and closes #6035

@viclafargue viclafargue requested review from a team as code owners August 22, 2024 14:41
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 22, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added Cython / Python Cython or Python issue CUDA/C++ labels Aug 22, 2024
@viclafargue viclafargue mentioned this pull request Aug 22, 2024
Closed
@Intron7
Copy link
Contributor

Intron7 commented Aug 23, 2024

@viclafargue Thank you for the fast fix can you rename repulsion_strength into gamma. That the name in UMAP's implementation and would make it easier for people to use it as a dropin replacement

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Aug 26, 2024
dantegd
dantegd previously requested changes Aug 26, 2024
View reviewed changes
python/cuml/cuml/manifold/simpl_set.pyx Show resolved Hide resolved
@dantegd
Copy link
Member

dantegd commented Aug 26, 2024

/ok to test

@divyegala
Copy link
Member

/ok to test

@divyegala
Copy link
Member

/merge

@bdice bdice dismissed dantegd’s stale review September 11, 2024 15:49

Previous requests addressed, and this needs to be merged to unblock Python 3.12

@rapids-bot rapids-bot bot merged commit 90d0622 into rapidsai:branch-24.10 Sep 11, 2024
54 checks passed
@divyegala divyegala mentioned this pull request Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd left review comments

@divyegala divyegala divyegala approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CUDA/C++ Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
4 participants
@viclafargue @Intron7 @dantegd @divyegala