Reenable pytest cuml-dask for CUDA 12.5 wheel CI tests
#6051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raydouglass
approved these changes
Aug 28, 2024
|
Seeing some of the tests failing due to NumPy 2 compatibility issues on CI. This is the same thing we have seen elsewhere: #6047 (comment) Think the reason we are getting NumPy 2 here is there is not a constraint on this dependency in cuML We are fixing both of these issues in PR: #6031 Have taken the changes in this PR and merged them into PR: #6031 That way we have all the CI fixes and skips in one place so we can hopefully clear out the CI issues in one go |
|
Thank you Divye for putting this and issue ( #6050 ) together! 🙏 |
Merged
jakirkham
changed the title
pytest cuml-dask for CUDA 12.5 wheel CI testspytest cuml-dask for CUDA 12.5 wheel CI tests
|
Have tweaked this to reenable the skipped wheel tests so we have somewhere to test and fix this issue Hope that is ok 🙂 |
dantegd
approved these changes
Sep 18, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #6050