Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune workflows based on changed files #6094

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner October 3, 2024 14:34
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 3, 2024
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me! I'm feeling more confident in my understanding of this workflow now.

One suggestion, and sorry I'd missed it on previous PRs in other repos... would you consider adding !.pre-commit-config.yaml to all these lists?

I'm thinking about the changes like rapidsai/build-planning#101. For those PRs where we modify pre-commit hook versions or configs, but where those modifications don't lead to any changes to e.g. Python or C++ source code files, it would be awesome to skip all test jobs.

I don't want to get too carried away with enumerating every root-level file, but think .pre-commit-config.yaml is a good candidate because it's present in almost every RAPIDS repo, and it tends to receive frequent updates.

Marking this "Approve" so that suggestion doesn't block merging, and so you can merge it without a re-review if you do implement it.

@KyleFromNVIDIA
Copy link
Contributor Author

Thanks @jameslamb. I've added an exception for .pre-commit-config.yaml based on your feedback.

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4df6a48 into rapidsai:branch-24.12 Oct 3, 2024
50 checks passed
KyleFromNVIDIA added a commit to KyleFromNVIDIA/cuml that referenced this pull request Oct 3, 2024
AyodeAwe pushed a commit that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants